Background Osteoporosis is one of the complications of diabetes mellitus. Additionally, it has been reported that both type 1, and type 2 diabetes mellitus are associated with an increased risk of osteoporosis-associated fractures. Decreased bone mineral density (BMD) and increased fracture risk have fairly consistently been observed in type 1 DM patients. However, the results in type 2 DM are variable, either increased, decreased or unchanged. Aim The aim of the current study is to assess the BMD in diabetic patients, either type 1 and type 2 DM and to assess the effect of patient sex on BMD, also the effect of diabetes control on bone mineral density. Patients and methods This study is a case-control study included 200 patients, divided into 2 groups: group IA included 50 patients having type 1 DM and group IB included 50 patients having type 2 DM. The average age of the patients was 34.610.3. Group II included 100 matched control with no DM, who are matched for age and sex. Clinical and anthropometric data were collected from all participants. Whole blood samples for fasting blood sugar, postprandial blood sugar, lipid profile, and HbA1c. Serum calcium, phosphorous, alkaline phosphatase, Vit D and PTH also DEXA scan were performed for all patients and control. Results: Diabetic patients have lower BMD measures than a normal person, DEXA examination of wrist, femoral and lumbar spine showed that normal T score was more frequent in type II than type I DM (56% versus 34%), (46% versus 22%), (58% versus 38%) respectively. Patients with type I were more frequently osteoporotic than type II DM (46% versus 20%), (50% versus 34%), (14% versus 2%) respectively, while osteopenia affected (20% versus 24%), (28% versus 20%), (24% versus 20%) respectively. Osteoporosis was found in 44.1% of the DM patients who had DM for > 10 years and in 44.1% of the patients who had DM for 5-10 years compared to 11.8% of the patients who had DM for <5 years mean, while 25% of the DM patients who